Summary:
D:/Work/Wombat Working/voter-registry/comment-info.txt
Changed the location of the protobufs file The location have been changed to create order in the packages
Changed the location of the ProtobufsMessages file so that the Registry file could use it freely
Changed the location of the Protobufs file and added the Registry class The protobufs files location was changed for the right location of the packages for Registry class be able to use the protobufs files
Changed the location of the ProtobufsMessages file for creating more organized project
Created the SimpleRegistry file SimpleRegistry expose the ability of manging voters information (their groups, and personal data)
Created RegistryTagTypes file this file have the different tags for registry messages
Changed the SimpleRegistry file started to implement the different methods of this class (such as created basic messages)
Changed the ProtobufMessages file now using only the basic registry messages
Changed the SimpleRegistry file Managed to create the signatory and add empty builder
Added the AccurateTimestamp file This file converts string timestamp to timestamp and the other way , its used for the SimpleRegistry tags
Moved the AccurateTimeStamp and the RegistryTagTypes to package called util This way the project files are more organized
Add the MessagesUtil file This file contain helpfull methods for working with messages (such as basicMessage and BulletinBoardMessage)
Created VoterRegistryMessage VoterRegistryMessage extending the abilities of the basic message also changed the name of MessagesUtils to CollectionMessagesUtils because its suits more this class destination
Changed the simpleRegistry file Edited the GetPersonIDDetails method , and refactored the basic methods of upload data to BulletinBoardServer
Added the SimpleRegistryTest This object tests the simple registry functionality
Added the SimpleRegistryTest This object tests the simple registry functionality
Changed the RegistryTagsType to RegistryTags The Name RegistryTags more indicative
Added The Wombat Code And Documentation This file describes the conventions of the wombat project
Changed the SimpleRegistry and VoterRegistryMessage Documentation The documentation was partial in part of the methods
Changed the SimpleRegistry to work with UnsignedBulletinBoardMessage The basicMessage is not needed
Changed the SimpleRegistry to work with UnsignedBulletinBoardMessage The basicMessage is not needed
Changed the VoterRegistryMessage to wrap UnsignedBulletinBoardMessage there is no need to wrap unused basic message when using UnsignedBulletinBoardMessage
Re-organized the voter-registry Since there no need for basicMessage i have removed it, and changed few methods to be in language level 7
Re-organized the voter-registry Since there no need for basicMessage i have removed it, and changed few methods to be in language level 7
added the RegistryInstance interface Which gives the basic registry functionality (because there going to be at least two registries)
Changed the SimpleRegistry The new Simple Registry works according to the RegistryInstance interface
Changed the SimpleRegistry The new Simple Registry works according to the RegistryInstance interface
Changed the SimpleRegistry The new Simple Registry works according to the RegistryInstance interface
Added testing to the SimpleRegistryTest class The Test checking that SetVoter AddVoter AddToGroup RemoveFromGroup methods working.
Added testing to the SimpleRegistryTest class The Test checking that SetVoter AddVoter AddToGroup RemoveFromGroup methods working.
Test Plan: The idea is to create number of BulletinBoardMessage's that and post them, then ask from the server for message with relevant filter and check that all the messages that have been posted there.
Reviewers: arbel.peled
Differential Revision: https://proj-cs.idc.ac.il/D1
Vladimir Eliezer Tokarev
Tal Moran
Arbel Deutsch Peled