diff --git a/distributed-key-generation/src/main/java/meerkat/crypto/dkg/feldman/Protocol.java b/distributed-key-generation/src/main/java/meerkat/crypto/dkg/feldman/Protocol.java index 84cff0b..f612b07 100644 --- a/distributed-key-generation/src/main/java/meerkat/crypto/dkg/feldman/Protocol.java +++ b/distributed-key-generation/src/main/java/meerkat/crypto/dkg/feldman/Protocol.java @@ -79,6 +79,7 @@ public class Protocol extends VerifiableSecretSharing { * it must be chosen such that computing discrete logarithms is hard in this group. * @param encoder Encode/Decode group elements (of type T) to/from byte array */ + //TODO: why the use of regular Random? Should it be changed? public Protocol(int t, int n, BigInteger zi, Random random, BigInteger q, T g , Group group, int id, ByteEncoder encoder) { super(t, n, zi, random, q, g,group); diff --git a/distributed-key-generation/src/main/java/meerkat/crypto/secretsharing/shamir/Polynomial.java b/distributed-key-generation/src/main/java/meerkat/crypto/secretsharing/shamir/Polynomial.java index 58f38fb..b00aec5 100644 --- a/distributed-key-generation/src/main/java/meerkat/crypto/secretsharing/shamir/Polynomial.java +++ b/distributed-key-generation/src/main/java/meerkat/crypto/secretsharing/shamir/Polynomial.java @@ -198,6 +198,7 @@ public class Polynomial implements Comparable { @Override public boolean equals(Object obj) { + //TODO: is this implementation correct? cannot understand its logic (hai) if(!super.equals(obj)) return false; Point other = (Point)obj;